Repository navigation
Switch map generator webp library to avoid C compiler requirement - #4879
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
WalkthroughThis PR updates the map generator to use a different WebP package, changes thumbnail encoding to use buffered ChangesMap generator WebP update
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you! I much prefer no CGO dependencies, and I think the difference of a few bytes between the images is probably fine. |
Resolves #4871
Description:
This replaces the webp encoder used in the map generator with one that does not require a C compiler to run. The errors in #4871 are what you get if you try to run the current map generator without a C compiler installed.
A small handful of thumbnails had minor differences when regenerated with the new encoder, presumably because of some minor difference in the encoder heuristics.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
feldrinh